Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electricity variables #7

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

enokandi
Copy link

The yaml file containing newly defined electricity grid variables has been added.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an initial set of review comments for this PR.

unit: nF
- Capacity|Electricity|Hydro|Pumped Storage:
description: Installed (available) capacity to generate electricity from hydropower pumped storage
unit: 'GW'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No quotation marks needed unless the unit (or any other attribute) starts with yaml-specific characters.

Suggested change
unit: 'GW'
unit: GW

@danielhuppmann
Copy link
Member

fyi @JKNTNU

@JKNTNU
Copy link
Contributor

JKNTNU commented Jan 8, 2025 via email

@enokandi
Copy link
Author

enokandi commented Jan 9, 2025

Thanks, dear Daniel, for your comments.

Before updating my PR, I wanted to ask about the level of freedom we have in defining variables. For example, for generation unit types, we have more detailed data than what is currently reflected in the existing nomenclature. Taking gas-fired generation units as an example, the nomenclature currently provides only “Capacity|Electricity|Gas.” However, we need more specificity, such as “Capacity|Electricity|Gas|Combined Cycle” or “Capacity|Electricity|Gas|Steam Turbine.”

I’m not sure if we’re allowed to define new variables like these or if doing so might cause conflicts with other variables, such as “Capacity|Electricity|Gas|w/ CC” or “Capacity|Electricity|Gas|w/o CC.”

@danielhuppmann
Copy link
Member

The newly added variables should be consistent with the variables in common-definitions, so specifically for your examples:

  1. There are variables like "Capacity|Electricity|Gas", so adding "Capacity|Electricity|Gas|Combined Cycle" in this project repository makes sense.
  2. There are variables like "Capital Cost|..." in common-definitions, so adding "Operational Cost|..." and "Fixed Cost|..." (or similar) makes sense.

Adding new variables.
Correcting syntax errors.
@enokandi
Copy link
Author

enokandi commented Jan 9, 2025

Thanks. I corrected the issues.
I used the 'Marginal Cost' since I believe it is more accurate than operational cost. However, if I have to use Operational Cost instead, please tell me.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few more suggestions plus an explanation for using tag-lists, which would make this file much readable and shorter.

Comment on lines 13 to 18
- Capacity|Electricity|Fossil|Gas Turbine:
description: Installed (available) capacity to generate electricity from fossil fuel gas turbines
unit: GW
- Capacity|Electricity|Fossil|Combined Cycle:
description: Installed (available) capacity to generate electricity from fossil fuel combined cycle plants
unit: GW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these variables really necessary? A gas turbine will always be used with Natural Gas, not other Fossil Fuels... Also, it is confusing that the other types of gas power plants are not listed here. So better to remove.

Copy link
Author

@enokandi enokandi Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Again Daniel. Thank you for your comments. The point is that the gas turbine units do not use natural gas as the fuel necessarily. The term "gas" in a gas turbine refers to the working fluid used to drive the turbine, similar to how steam is used in steam turbines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough (I meant that oil-based gas turbines are probably not really used any more, right?).

But that still doesn't mean that we need a part-aggregate "Fossil". After all, you could also run it with Hydrogen, which could or could not be from fossil sources...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Sorry for the misunderstanding on my part.
However, in our dataset, we still have a considerable installed capacity of gas turbine units using various primary fuels, so I had to include all of them.

Regarding "Fossil," I used this term to classify the diesel generation units in my dataset because "Diesel" was not listed as a separate category in the common nomenclature.

- Capacity|Electricity|Hydro|Run of River:
description: Installed (available) capacity to generate electricity from hydropower run-of-river plants
unit: GW
- Capacity|Electricity|Solar|Thermal:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a thing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. These units utilize sunlight to heat fluids, generating steam to drive turbines and produce electricity. Spain, particularly, has a considerable installed capacity of this type.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, if you think adding a new technology like this might be challenging for the nomenclature used throughout the whole project, I can omit it and categorize those units simply as solar units.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, is that the same as Concentrated Solar Power (CSP)? If yes, I suggest to use CSP to remain consistent with common-definitions.

There, we use "Final Energy|Solar" for thermal heat, but for water-heating, see here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Thanks for pointing it out.
I removed Capacity|Electricity|Solar|Thermal and replaced Thermal with CSP for Marginal Cost|Electricity|Solar|CSP.

Comment on lines 19 to 30
- Capacity|Electricity|Gas|Combined Cycle:
description: Installed (available) capacity to generate electricity from natural gas combined cycle plants
unit: GW
- Capacity|Electricity|Gas|Gas Turbine:
description: Installed (available) capacity to generate electricity from natural gas gas turbines
unit: GW
- Capacity|Electricity|Gas|Integrated Gasification Combined Cycle:
description: Installed (available) capacity to generate electricity from integrated gasification combined cycle plants
unit: GW
- Capacity|Electricity|Gas|Steam Turbine:
description: Installed (available) capacity to generate electricity from natural gas steam turbines
unit: GW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could simplify this file by using a tag-list, so creating a separate file tag_power_turbine_types.yaml (or similar) that has

- Turbine Type:
    - Combined Cycle:
        description: combined-cycle (CC)
    - Gas Turbine:
         description: gas turbines (GT)
    - Integrated Gasification Combined-Cycle:
        description: integrated gasification combined cycle plants (IGCC)
    - Steam Turbine:
        description: steam turbines

And then simplify this section

Suggested change
- Capacity|Electricity|Gas|Combined Cycle:
description: Installed (available) capacity to generate electricity from natural gas combined cycle plants
unit: GW
- Capacity|Electricity|Gas|Gas Turbine:
description: Installed (available) capacity to generate electricity from natural gas gas turbines
unit: GW
- Capacity|Electricity|Gas|Integrated Gasification Combined Cycle:
description: Installed (available) capacity to generate electricity from integrated gasification combined cycle plants
unit: GW
- Capacity|Electricity|Gas|Steam Turbine:
description: Installed (available) capacity to generate electricity from natural gas steam turbines
unit: GW
- Capacity|Electricity|Gas|{Turbine Type}:
description: Installed (available) capacity to generate electricity with natural gas
using {Turbine Type} plants
unit: GW

Same for all other variables that use all combinations of turbines.

This produces a much more concise and readable variable list file. The nomenclature package will automatically create all permutations during scenario validation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I will do it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done now.

enokandi and others added 4 commits January 10, 2025 12:21
Correcting the description of Active Power|Electricity|Demand [Share]

Co-authored-by: Daniel Huppmann <[email protected]>
Correcting the unit of the Active Power|Electricity|Demand [Share]

Co-authored-by: Daniel Huppmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants